Skip to content

issue: [2717] coverage calculation improvments #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DanteUkraine
Copy link
Contributor

@DanteUkraine DanteUkraine commented May 23, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

As a user of coverage feature I faced need to see total and covered numbers of queries and mutations.
So I decided to apply improvements.

Fixes # (2717)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I updated existing unit tests.

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: 703a381

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-inspector/coverage-command Major
@graphql-inspector/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@TuvalSimha TuvalSimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is looking good, can you please rebase to master? we did some major changes regarding to Node versions.

TuvalSimha and others added 24 commits May 27, 2024 12:20
* Upgrade Yoga to version 5

* ?

* prettier

* chore(dependencies): updated changesets for modified dependencies

* ?

* ?

* ?

* ?

* ??

* ?

* ?

* changesets

* ?

* ?

* ?

* prettier

* ?

* ?

* ?

* chore(dependencies): updated changesets for modified dependencies

* ?

* ?

* ?

* ?

* prettier

* ?

* prettier?

* pnpm engine not necessary in packages

* unnecessary .npmrc

* bump pnpm

* disable-pre-post-scripts

* use packageManager pnpm version

* changeset major

* action on node 20

* changeset

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: enisdenjo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Test release: fix the release for config and loaders

* fix?

* config version

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix package version number

* prettier

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix packages version for loaders + config

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix loaders package version

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update graphql-tools

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ve#2675)

* fix(deps): update dependency probot to v12.3.3 [security]

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ve#2670)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-hive#2665)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…raphql-hive#2744)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ve#2668)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update all packages dependencies versions

* pnpm prettier & install

* smee-client

* theguild/eslint-config

* update eslintrc

* eslintrc update rules

* figures

* sentry/node & sentry/tracing & whatwg-node/fetch & fix figures

* no figures

* rimraf

* log-symbols

* nock

* no log-symbols

* lint-staged

* types/js-yaml

* object-inspect & immer

* std-env

* @babel/core

* actions/core

* yoga

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix Docker file release

* prettier
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2754)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@DanteUkraine
Copy link
Contributor Author

I guess this is looking good, can you please rebase to master? we did some major changes regarding to Node versions.

rebase done.

@DanteUkraine DanteUkraine requested a review from TuvalSimha May 27, 2024 09:22
@TuvalSimha
Copy link
Collaborator

Hey @DanteUkraine
thank you very much!
any chance you can rebase and commit only your changes? it become to hard for me to review this pull request before merge this :)

@DanteUkraine
Copy link
Contributor Author

DanteUkraine commented May 30, 2024

I guess this is looking good, can you please rebase to master? we did some major changes regarding to Node versions.

@TuvalSimha Ok, I did new PR, #2775

@DanteUkraine DanteUkraine deleted the coverage-improvment branch May 30, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants